diff --git a/go.mod b/go.mod index f588aaf..dd706c6 100644 --- a/go.mod +++ b/go.mod @@ -6,7 +6,7 @@ require ( github.com/antonfisher/nested-logrus-formatter v1.1.0 github.com/edwarnicke/exechelper v1.0.2 github.com/kelseyhightower/envconfig v1.4.0 - github.com/networkservicemesh/sdk v0.0.0-20210120064752-943735566550 + github.com/networkservicemesh/sdk v0.0.0-20210122163758-b1f2892a6728 github.com/sirupsen/logrus v1.7.0 github.com/spiffe/go-spiffe/v2 v2.0.0-alpha.4.0.20200528145730-dc11d0c74e85 github.com/stretchr/testify v1.6.1 diff --git a/go.sum b/go.sum index 090833c..ba1e0ad 100644 --- a/go.sum +++ b/go.sum @@ -284,8 +284,8 @@ github.com/nats-io/stan.go v0.6.0/go.mod h1:eIcD5bi3pqbHT/xIIvXMwvzXYElgouBvaVRf github.com/nbutton23/zxcvbn-go v0.0.0-20180912185939-ae427f1e4c1d/go.mod h1:o96djdrsSGy3AWPyBgZMAGfxZNfgntdJG+11KU4QvbU= github.com/networkservicemesh/api v0.0.0-20210112152104-45029fb10e27 h1:J0UPj3sYfEvXwMHyAOiQ++NU7a3cZGZST1s1ftyC0uQ= github.com/networkservicemesh/api v0.0.0-20210112152104-45029fb10e27/go.mod h1:qvxdY1Zt4QTtiG+uH1XmjpegeHjlt5Jj4A8iK55iJPI= -github.com/networkservicemesh/sdk v0.0.0-20210120064752-943735566550 h1:2dfh+H5pqTJKcAodLk1wi5+fhu1y4AxoobPVGmgR0yM= -github.com/networkservicemesh/sdk v0.0.0-20210120064752-943735566550/go.mod h1:LV9NIA44LDUs0moEnrfeeRKQPA3Qdu3JiBhSwzEbXSM= +github.com/networkservicemesh/sdk v0.0.0-20210122163758-b1f2892a6728 h1:+5IMj2KvZR7wOC/5229YVPSMXTLp/SMIybQemxEaYtg= +github.com/networkservicemesh/sdk v0.0.0-20210122163758-b1f2892a6728/go.mod h1:LV9NIA44LDUs0moEnrfeeRKQPA3Qdu3JiBhSwzEbXSM= github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e h1:fD57ERR4JtEqsWbfPhv4DMiApHyliiK5xCTNVSPiaAs= github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e/go.mod h1:zD1mROLANZcx1PVRCS0qkT7pwLkGfwJo4zjcN/Tysno= github.com/nishanths/exhaustive v0.0.0-20200811152831-6cf413ae40e0/go.mod h1:wBEpHwM2OdmeNpdCvRPUlkEbBuaFmcK4Wv8Q7FuGW3c= diff --git a/main.go b/main.go index affa3d6..f2efa1a 100644 --- a/main.go +++ b/main.go @@ -1,4 +1,4 @@ -// Copyright (c) 2020 Doc.ai and/or its affiliates. +// Copyright (c) 2020-2021 Doc.ai and/or its affiliates. // // SPDX-License-Identifier: Apache-2.0 // @@ -23,8 +23,10 @@ import ( "os" "time" + "github.com/networkservicemesh/sdk/pkg/tools/logger/logruslogger" + "github.com/networkservicemesh/sdk/pkg/tools/jaeger" - "github.com/networkservicemesh/sdk/pkg/tools/spanhelper" + "github.com/networkservicemesh/sdk/pkg/tools/opentracing" "github.com/networkservicemesh/sdk/pkg/registry/chains/proxydns" @@ -38,7 +40,7 @@ import ( "github.com/networkservicemesh/sdk/pkg/tools/debug" "github.com/networkservicemesh/sdk/pkg/tools/grpcutils" - "github.com/networkservicemesh/sdk/pkg/tools/log" + "github.com/networkservicemesh/sdk/pkg/tools/logger" "github.com/networkservicemesh/sdk/pkg/tools/signalctx" ) @@ -57,15 +59,17 @@ func main() { // Setup logging logrus.SetFormatter(&nested.Formatter{}) - logrus.SetLevel(logrus.TraceLevel) - ctx = log.WithField(ctx, "cmd", os.Args[0]) + ctx, _ = logruslogger.New( + logger.WithFields(ctx, map[string]interface{}{"cmd": os.Args[0]}), + ) // Debug self if necessary if err := debug.Self(); err != nil { - log.Entry(ctx).Infof("%s", err) + logger.Log(ctx).Infof("%s", err) } // Configure open tracing + logger.EnableTracing(true) jaegerCloser := jaeger.InitJaeger("cmd-registry-proxy-dns") defer func() { _ = jaegerCloser.Close() }() @@ -80,7 +84,7 @@ func main() { logrus.Fatalf("error processing config from env: %+v", err) } - log.Entry(ctx).Infof("Config: %#v", config) + logger.Log(ctx).Infof("Config: %#v", config) // Get a X509Source source, err := workloadapi.NewX509Source(ctx) @@ -95,10 +99,10 @@ func main() { tlsCreds := credentials.NewTLS(tlsconfig.MTLSServerConfig(source, source, tlsconfig.AuthorizeAny())) // Create GRPC Server and register services - options := append(spanhelper.WithTracing(), grpc.Creds(tlsCreds)) + options := append(opentracing.WithTracing(), grpc.Creds(tlsCreds)) server := grpc.NewServer(options...) - clientOptions := append(spanhelper.WithTracingDial(), grpc.WithBlock(), grpc.WithTransportCredentials(tlsCreds)) + clientOptions := append(opentracing.WithTracingDial(), grpc.WithBlock(), grpc.WithTransportCredentials(tlsCreds)) proxydns.NewServer(ctx, net.DefaultResolver, config.Domain, &config.ProxyNSMgrURL, clientOptions...).Register(server) for i := 0; i < len(config.ListenOn); i++ { @@ -106,7 +110,7 @@ func main() { exitOnErr(ctx, cancel, srvErrCh) } - log.Entry(ctx).Infof("Startup completed in %v", time.Since(startTime)) + logger.Log(ctx).Infof("Startup completed in %v", time.Since(startTime)) <-ctx.Done() } @@ -114,13 +118,13 @@ func exitOnErr(ctx context.Context, cancel context.CancelFunc, errCh <-chan erro // If we already have an error, log it and exit select { case err := <-errCh: - log.Entry(ctx).Fatal(err) + logger.Log(ctx).Fatal(err) default: } // Otherwise wait for an error in the background to log and cancel go func(ctx context.Context, errCh <-chan error) { err := <-errCh - log.Entry(ctx).Error(err) + logger.Log(ctx).Error(err) cancel() }(ctx, errCh) } diff --git a/main_test.go b/main_test.go index 56b6e82..d07ca71 100644 --- a/main_test.go +++ b/main_test.go @@ -1,4 +1,4 @@ -// Copyright (c) 2020 Doc.ai and/or its affiliates. +// Copyright (c) 2020-2021 Doc.ai and/or its affiliates. // // SPDX-License-Identifier: Apache-2.0 // @@ -41,6 +41,7 @@ import ( main "github.com/networkservicemesh/cmd-registry-proxy-dns" + "github.com/networkservicemesh/sdk/pkg/tools/logger" "github.com/networkservicemesh/sdk/pkg/tools/spire" ) @@ -57,7 +58,7 @@ type RegistryTestSuite struct { func (t *RegistryTestSuite) SetupSuite() { logrus.SetFormatter(&nested.Formatter{}) - logrus.SetLevel(logrus.TraceLevel) + logger.EnableTracing(true) t.ctx, t.cancel = context.WithCancel(context.Background()) // Run spire diff --git a/pkg/imports/imports.go b/pkg/imports/imports.go index 4574671..ac64818 100644 --- a/pkg/imports/imports.go +++ b/pkg/imports/imports.go @@ -4,16 +4,18 @@ package imports import ( _ "context" _ "fmt" - _ "net" - _ "net/url" - _ "os" - _ "path/filepath" - _ "testing" - _ "time" - _ "github.com/antonfisher/nested-logrus-formatter" _ "github.com/edwarnicke/exechelper" _ "github.com/kelseyhightower/envconfig" + _ "github.com/networkservicemesh/sdk/pkg/registry/chains/proxydns" + _ "github.com/networkservicemesh/sdk/pkg/tools/debug" + _ "github.com/networkservicemesh/sdk/pkg/tools/grpcutils" + _ "github.com/networkservicemesh/sdk/pkg/tools/jaeger" + _ "github.com/networkservicemesh/sdk/pkg/tools/logger" + _ "github.com/networkservicemesh/sdk/pkg/tools/logger/logruslogger" + _ "github.com/networkservicemesh/sdk/pkg/tools/opentracing" + _ "github.com/networkservicemesh/sdk/pkg/tools/signalctx" + _ "github.com/networkservicemesh/sdk/pkg/tools/spire" _ "github.com/sirupsen/logrus" _ "github.com/spiffe/go-spiffe/v2/bundle/x509bundle" _ "github.com/spiffe/go-spiffe/v2/spiffetls/tlsconfig" @@ -24,13 +26,10 @@ import ( _ "google.golang.org/grpc" _ "google.golang.org/grpc/credentials" _ "google.golang.org/grpc/health/grpc_health_v1" - - _ "github.com/networkservicemesh/sdk/pkg/registry/chains/proxydns" - _ "github.com/networkservicemesh/sdk/pkg/tools/debug" - _ "github.com/networkservicemesh/sdk/pkg/tools/grpcutils" - _ "github.com/networkservicemesh/sdk/pkg/tools/jaeger" - _ "github.com/networkservicemesh/sdk/pkg/tools/log" - _ "github.com/networkservicemesh/sdk/pkg/tools/signalctx" - _ "github.com/networkservicemesh/sdk/pkg/tools/spanhelper" - _ "github.com/networkservicemesh/sdk/pkg/tools/spire" + _ "net" + _ "net/url" + _ "os" + _ "path/filepath" + _ "testing" + _ "time" )