fix: adjust dependencies and exports #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
approved these changes
May 6, 2025
| } | ||
|
|
||
| export function netlify(options: NetlifyPluginOptions = {}): any { | ||
| export default function netlify(options: NetlifyPluginOptions = {}): any { |
There was a problem hiding this comment.
It's a weird one! Basically if I use the right type here it gives me an error on the consumer side because TypeScript finds two Vite instances: one from the plugin and one from the consumer site. This makes it throw an error. I'm sure there's a better way to handle it, but I'm going with this for now.
There was a problem hiding this comment.
Yeah, I ran into the same thing with the Remix/RR7 Vite plugins.
I haven't looked carefully at the implementation carefully yet, but shouldn't you be able to mark vite as a dev dep and only specify a peer dep range? In the Vite plugins I've worked on at least, I only needed types from vite, no runtime imports.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@netlify/runtimemodule needs@netlify/cacheand@netlify/runtime-utilsas runtime dependencies, not just development