fix(perf): join excluded extensions into one regex instead of spreading into multiple regexes #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o multiple regexes
✅ Deploy Preview for csp-nonce ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jasonbarry
changed the title
eduardoboucas
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the excludedPaths regexes by joining all of the excluded extensions into a single regex, vs spreading them into multiple. In turns out that joining all into a single regex is much more performant (Slack thread). Closes #46
To test, go to https://deploy-preview-49--csp-nonce.netlify.app, and with a clean/fresh browser cache, inspect the response headers for the document html, and for the 404ing favicon.ico. The document html should have the
x-debug-csp-nonce: invokedresponse header, whereas the favicon.ico resource should not.You can try this on https://deploy-preview-18839--app.netlify.com too -- only the document html should have
x-debug-csp-nonce: invoked, and not any of the other JS/CSS/etc assets.