Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip purgeCache in local dev #472

Merged
merged 2 commits into from
Feb 13, 2024
Merged

fix: skip purgeCache in local dev #472

merged 2 commits into from
Feb 13, 2024

Conversation

ascorbic
Copy link
Contributor

Which problem is this pull request solving?

Currently running purgeCache in local development throws an error. While I wouldn't expect it to actually purge anything (because there's no cache anyway), this prevents us running dev for any site that does use this.

Describe the solution you've chosen

Log a message and return if called in local dev without a token. If a token is passed I assume the user knows what they're doing and wants it to work for real.

Describe alternatives you've considered

Example: Another solution would be [...]

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • The status checks are successful (continuous integration). Those can be seen below.

@ascorbic ascorbic requested a review from a team as a code owner February 13, 2024 11:36
src/lib/purge_cache.ts Outdated Show resolved Hide resolved
Co-authored-by: Marcus Weiner <[email protected]>
@kodiakhq kodiakhq bot merged commit 9236053 into main Feb 13, 2024
6 checks passed
@kodiakhq kodiakhq bot deleted the local-purge-cache branch February 13, 2024 12:42
kodiakhq bot pushed a commit that referenced this pull request Feb 13, 2024
🤖 I have created a release *beep* *boop*
---


## [2.6.0](v2.5.1...v2.6.0)
(2024-02-13)


### Features

* publish ESM version
([#473](#473))
([b1b7553](b1b7553))


### Bug Fixes

* **deps:** update dependency @netlify/serverless-functions-api to
v1.13.1 ([#462](#462))
([29b33ae](29b33ae))
* **deps:** update dependency @netlify/serverless-functions-api to
v1.14.0 ([#470](#470))
([c77eb33](c77eb33))
* skip purgeCache in local dev
([#472](#472))
([9236053](9236053))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants