style: lint all files

I modernized the eslint configuration Back in 25fcdd8. At the time, I
chose not to make any changes to the list of filepaths we historically
passed to eslint, thinking that maybe this would include a bunch of
files (like fixtures) that we intentionally ignore.

This turned out to be not the best idea. I didn't notice at the time
that the list of filepaths was not great to begin with: We were passing
a bunch of file extensions (mjs, cjs) that we no longer have in the
repository, and other extensions (md, html) that ESLint doesn't lint.

Since ESLint 9, you no longer ever really have reason to pass a path or
paths to `eslint` (e.g. you often used to pass `.`, but this is now the
implied default). So, this change just changes our use of ESLint to
match what the project recommends.

This change exposed a lot of unlinted files, so I've fixed or suppressed
a minimum of errors in this PR. We can fix these suppressions as we go.

Author: ndhoule

e2e/install.e2e.ts

@@ -2,7 +2,6 @@ import http from 'node:http'
 import os from 'node:os'
 import events from 'node:events'
 import { existsSync } from 'node:fs'
-import { execSync } from 'node:child_process'
 import fs from 'node:fs/promises'
 import { platform } from 'node:os'
 import path from 'node:path'
@@ -160,7 +159,7 @@ const tests: [packageManager: string, config: { install: [cmd: string, args: str
   ],
 ]
 
-describe.each(tests)('%s → installs the cli and runs the help command without error', (packageManager, config) => {
+describe.each(tests)('%s → installs the cli and runs the help command without error', (_, config) => {
   itWithMockNpmRegistry('installs the cli and runs the help command without error', async ({ registry }) => {
     const cwd = registry.cwd
     await execa(...config.install, {

eslint.config.js

@@ -8,6 +8,8 @@ import node from 'eslint-plugin-n'
 import vitest from '@vitest/eslint-plugin'
 import tseslint from 'typescript-eslint'
 
+import cliTemporarySuppressions from './eslint_temporary_suppressions.js'
+
 const __filename = fileURLToPath(import.meta.url)
 const __dirname = path.dirname(__filename)
 
@@ -140,23 +142,7 @@ export default tseslint.config(
     },
   },
 
-  // XXX: Temporarily disabled rules: These rules are disabled because we have offending code that we haven't yet fixed.
-  {
-    rules: {
-      // Empty functions and blocks are useful (e.g `noop() {}`, `catch {}`) but can mask unintentionally omitted
-      // implementation. We should add explanatory comments like `// intentionally empty` and `// ignore error` in these
-      // scenarios to communicate intent.
-      'no-empty': 'off',
-      '@typescript-eslint/no-empty-function': 'off',
-
-      'n/no-unsupported-features/node-builtins': [
-        'error',
-        {
-          ignores: ['FormData', 'ReadableStream', 'Response', 'Request', 'fetch', 'fs/promises.cp'],
-        },
-      ],
-    },
-  },
+  ...cliTemporarySuppressions,
 
   // Must be last
   prettier,