This repository has been archived by the owner on Oct 19, 2022. It is now read-only.
Merge changes from upstream v.1.1.0 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add TypeScript to **Popular Alternatives**
Adds support for the error overlay to detect and open the file with the error in MacVim. Relates to facebook#2636.
* Update README.md with a note that reminds users to prepend REACT_APP_ to their environment variables. * Based on facebook#865, where Dan Abramov suggests the person who filed the issue create a PR with these changes. * Took the language from [Adding Custom Environment Variables](https://github.com/facebookincubator/create-react-app/tree/master/packages/react-scripts/template#adding-custom-environment-variables)
* add support to set REACT_EDITOR to none * change README message * change condition to avoid problems with editor being null * move condition to avoid extra code
* add link to deployment docs after build * Update printHostingInstructions.js
* Use latest npm in e2e tests * Keep default npm version in "simple" test * Try to fix CI by using a version that supports Yarn
* Try to use Yarn in more E2E scripts * Keep using npm pack * Maybe this will fix Windows? * Try this
* Separate old Node E2E test * Try this for old node
* Run e2e-simple in a realistic scenario * Use npx for everything * oops
* Convert e2e-installs * Convert kitchensink tests * Upgrade npm for kitchensink
* This doesn't look needed anymore * Remove unnecessary rebuilds
It's been here long enough.
* Switch to Yarn Workspaces * Feedback * Move flowconfig * Use publish script * Keep git status check * Fix Flow without perf penalty * Remove Flow from package.json "test" * Try running it from script directly (?) * Try magic incantations * lol flow COME ON * Try to skip Flow on AppVeyor * -df * -df * -df * Try to fix CI * Revert unrelated changes * Update CONTRIBUTING.md
* This is a good default. Adds approx 4 seconds to install time, but can save some headaches. * Add no lockfile for add, too
All FB open source projects including this one enforce [our code of conduct](https://code.facebook.com/pages/876921332402685/open-source-code-of-conduct), but I just realized we haven't explicitly linked to it from a Markdown file. So I'm doing just that.
* Bump detect-port-alt * Bump again
* Always include destructuring transform * Fix lint
* Add warning when HOST environment variable is set (facebook#3719) * Improve HOST environment variable warning message * Adjust text and message Closes facebook#3719
* Test Node 9 on CI * Oops
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge changes from upstream up to version 1.1.0.