fix(adapter-puppeteer): Do not intercept CORS preflight requests #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CORs test is failing in CI |
offirgolan
commented
Aug 10, 2018
| try { | ||
| responseBody = await response.text(); | ||
| } catch (error) { | ||
| /* |
There was a problem hiding this comment.
This is no longer needed since im resolving the promise on requestfinished instead of on response. That's where it should have been resolving in the first place.
offirgolan
commented
Aug 10, 2018
| @@ -1,10 +1,11 @@ | |||
| import Adapter from '@pollyjs/adapter'; | |||
| import { URL } from '@pollyjs/utils'; | |||
There was a problem hiding this comment.
Using url-parse instead of node's URL as it is a consistent API across node versions and the browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #87.