fix(persister): Handle concurrent find requests #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmit
reviewed
Aug 8, 2018
| it('should handle concurrent find requests', async function() { | ||
| await Promise.all([ | ||
| this.persister.find('test'), | ||
| this.persister.find('test'), |
There was a problem hiding this comment.
Can we update the test to assert when adding another recordingId that it will increment?
i.e.:
this.persister.find('foo');
this.persister.find('foo');
this.persister.find('bar ');
/* count 2 */
Can you also add tests where a mutation, like delete, is done in between finds. Feels like a possible race condition. After this change, the second find would return the result of the first - correct? Which would not be valid. Since it was really deleted. In either case, we should add tests around this and patch any bugs. . You already added tests in the file previously that covers this :)
jasonmit
reviewed
Aug 8, 2018
| const { _cache: cache } = this; | ||
|
|
||
| if (!cache.has(recordingId)) { | ||
| const findRecording = async () => { |
There was a problem hiding this comment.
Might be worth naming this anonymous fn for a better callstack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.