feat: Node File System Persister #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
offirgolan
commented
Jul 11, 2018
•
offirgolan
commented
- File System Persister
- Node tests
jasonmit
reviewed
Jul 11, 2018
docs/persisters/fs.md
Outdated
| _Type_: `String` | ||
| _Default_: `'recordings'` | ||
|
|
||
| The root directory to store all recordings. |
There was a problem hiding this comment.
Are absolute paths supported as well? Might want to mention
jasonmit
reviewed
Jul 11, 2018
| constructor(recordingsDir) { | ||
| this.recordingsDir = recordingsDir; | ||
| constructor(options = {}) { | ||
| this.recordingsDir = options.recordingsDir; |
There was a problem hiding this comment.
Should we throw if no recordingDir?
jasonmit
reviewed
Jul 11, 2018
| Pass the data through the base persister's stringify method so | ||
| the output will be consistent with the rest of the persisters. | ||
| */ | ||
| this.api.saveRecording(recordingId, parse(this.stringify(data))); |
There was a problem hiding this comment.
Any reason for no return since saveRecording does have a return value?
There was a problem hiding this comment.
The other persisters don't return anything from saveRecording.
jasonmit
reviewed
Jul 11, 2018
| } | ||
|
|
||
| deleteRecording(recordingId) { | ||
| this.api.deleteRecording(recordingId); |
There was a problem hiding this comment.
The other persisters don't return anything from deleteRecording .
jasonmit
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.