Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set response status to 200 by default #6

Closed
Turbo87 opened this issue Jun 10, 2018 · 1 comment
Closed

Set response status to 200 by default #6

Turbo87 opened this issue Jun 10, 2018 · 1 comment

Comments

@Turbo87
Copy link

Turbo87 commented Jun 10, 2018

In most cases right now I'm using something like

res.status(200);
res.json({ ... });

but I think that could be simplified by making status: 200 the default, which is currently set to null according to the logging.

Is there any reason why 200 should not be the default?
@jasonmit
Copy link
Contributor

Seems reasonable, we'll make the change.

offirgolan added a commit that referenced this issue Jun 11, 2018
@offirgolan
feat(core): Default Response status code to 200
f42a281 
Resolved #6.
@offirgolan offirgolan mentioned this issue Jun 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Turbo87 @jasonmit