fix(persister): requests
-> request
in HarEntry
declaration
#441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix typo in
HarEntry
type declaration. In reality, the property is calledrequest
but the declaration usesrequests
instead.Motivation and Context
See above.
In addition to this fix, the declaration is also lacking the
_recordingName
andcreator
properties forHarLog
instances, but I'm not sure how to best handle these as they are added by the base persister implementation, so it could be possible that a custom persister omits these properties. Perhaps theHarLog
declaration should be made generic to handle this? Happy to add it to this PR in case that's desired.Types of Changes
Checklist