Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(persister): requests -> request in HarEntry declaration #441

Merged
merged 1 commit into from
Feb 7, 2022
Merged

fix(persister): requests -> request in HarEntry declaration #441

merged 1 commit into from
Feb 7, 2022

Conversation

ROpdebee
Copy link
Contributor

Description

Fix typo in HarEntry type declaration. In reality, the property is called request but the declaration uses requests instead.

Motivation and Context

See above.

In addition to this fix, the declaration is also lacking the _recordingName and creator properties for HarLog instances, but I'm not sure how to best handle these as they are added by the base persister implementation, so it could be possible that a custom persister omits these properties. Perhaps the HarLog declaration should be made generic to handle this? Happy to add it to this PR in case that's desired.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My code follows the code style of this project.
  • My commits and the title of this PR follow the Conventional Commits Specification.
  • I have read the contributing guidelines.

@ROpdebee ROpdebee changed the title fix(persister): requests -> request in HarEntry fix(persister): requests -> request in HarEntry declaration Dec 18, 2021
@offirgolan
Copy link
Collaborator

Thanks for the PR @ROpdebee!

@offirgolan offirgolan merged commit 6466810 into Netflix:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants