Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add types.d.ts to package.files #431

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

jomaxx
Copy link
Contributor

@jomaxx jomaxx commented Dec 6, 2021

Description

Added types.d.ts to package.files for each package that has package.types configured.

Motivation and Context

types.d.ts files were added to each package recently (#428) but don't get published to npm.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My code follows the code style of this project.
  • My commits and the title of this PR follow the Conventional Commits Specification.
  • I have read the contributing guidelines.

@offirgolan
Copy link
Collaborator

ooooo 😅 thanks for the fix!

@offirgolan offirgolan merged commit 113ee89 into Netflix:master Dec 6, 2021
@jomaxx
Copy link
Contributor Author

jomaxx commented Dec 6, 2021

@offirgolan no problem! thanks for the quick review and for previously adding the types! :)

@jomaxx jomaxx deleted the fix-types branch December 6, 2021 22:44
@offirgolan
Copy link
Collaborator

Released with v6.0.1. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants