Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Use base64 instead of hex encoding for binary data #420

Merged
merged 2 commits into from
Nov 28, 2021

Conversation

offirgolan
Copy link
Collaborator

Resolves #371

@offirgolan offirgolan changed the title feat: Use base64 instead of hex encoding for binary data feat!: Use base64 instead of hex encoding for binary data Nov 28, 2021
@offirgolan offirgolan merged commit 6bb9b36 into master Nov 28, 2021
@offirgolan offirgolan deleted the base64-encoding branch November 28, 2021 00:56
@roschaefer
Copy link

@offirgolan @netflixgithub could you please release @pollyjs/adapter-node-http and the other packages affected by this PR? The last time it was Published a year ago.

I'm trying to decode a _isBinary response object in an beforePersist hook. Kind of similar to what @renanvalentin asked for here. Is there a way to always save a response as utf-8 (avoid _isBinary) in order to filter sensitive data before persisting?

@offirgolan
Copy link
Collaborator Author

@roschaefer this PR was published with v6.0.0 ~2 months ago.

@roschaefer
Copy link

Yep, my bad. I was looking at the @types/pollyjs__adapter-node-http package. Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants