Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adapter-puppeteer): Add prependListener [email protected] removed #368

Merged
merged 2 commits into from
Dec 12, 2020
Merged

Conversation

RFC2109
Copy link
Contributor

@RFC2109 RFC2109 commented Nov 12, 2020

Description

puppeteer remove prependListener after v4.0.0, add it if missing

Motivation and Context

Resolves #345

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My code follows the code style of this project.
  • My commits and the title of this PR follow the Conventional Commits Specification.
  • I have read the contributing guidelines.

@Anikethana
Copy link

@jasonmit looks like this patch fixes #345

@jasonmit
Copy link
Contributor

jasonmit commented Nov 18, 2020

Deferring this to @offirgolan who wrote the puppeteer adapter. My main concern is it's mutating target which we do not own.

@jasonmit jasonmit requested a review from offirgolan November 18, 2020 20:49
@Anikethana
Copy link

@offirgolan can we get your help here.

Deferring this to @offirgolan who wrote the puppeteer adapter. My main concern is it's mutating target which we do not own.

@serzhshakur
Copy link

Is there any change to have this reviewed/merged any time soon? That is quite a pain having this broken.

@jasonmit jasonmit requested a review from offirgolan December 11, 2020 21:44
@offirgolan offirgolan merged commit 6c35fd3 into Netflix:master Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[adapter-puppeteer] package is broken with Puppeteer 4 - removed prependListener and removeListener
5 participants