Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove deprecated Persister.name and Adapter.name #343

Merged
merged 2 commits into from
Jun 6, 2020

Conversation

offirgolan
Copy link
Collaborator

Description

Since we're going to publish a major release, this is a good time to fully remove support for Factory.name.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My code follows the code style of this project.
  • My commits and the title of this PR follow the Conventional Commits Specification.
  • I have read the contributing guidelines.

@offirgolan offirgolan requested a review from jasonmit June 5, 2020 22:21
@jasonmit
Copy link
Contributor

jasonmit commented Jun 5, 2020

LGTM just need to delete the tests around this as well

@offirgolan offirgolan merged commit 1223ba0 into master Jun 6, 2020
@offirgolan offirgolan deleted the remove-deprecated-factory-name branch June 6, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants