Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adapter-fetch): Add statusText to the response #341

Merged
merged 2 commits into from
Jun 5, 2020
Merged

fix(adapter-fetch): Add statusText to the response #341

merged 2 commits into from
Jun 5, 2020

Conversation

josex2r
Copy link
Contributor

@josex2r josex2r commented Jun 4, 2020

Description

Adds the property statusText to the response returned by fetch.

Motivation and Context

The Response object created by the fetch-adapter may return more info, this could be useful to simulare a real request to the server.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My code follows the code style of this project.
  • My commits and the title of this PR follow the Conventional Commits Specification.
  • I have read the contributing guidelines.

Copy link
Collaborator

@offirgolan offirgolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @josex2r. Once the test changes are fixed I'll go ahead and get this merged.

@offirgolan offirgolan merged commit 0d45953 into Netflix:master Jun 5, 2020
@josex2r josex2r deleted the fetch-statusText branch June 8, 2020 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants