feat(adapter-xhr): Add support for handling binary data #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked by sinonjs/nise#164 |
jasonmit
approved these changes
May 15, 2020
packages/@pollyjs/adapter-xhr/tests/integration/adapter-test.js
Outdated
Show resolved
Hide resolved
offirgolan
commented
May 17, 2020
| @@ -40,9 +40,10 @@ | |||
| "watch-all": "npm-run-all --parallel build:watch test:build:watch" | |||
| }, | |||
| "dependencies": { | |||
| "@offirgolan/nise": "^4.1.0", | |||
There was a problem hiding this comment.
Using a user scoped package with sinonjs/nise#164 until it gets merged upstream.
offirgolan
commented
May 18, 2020
| @@ -99,7 +99,7 @@ | |||
| "lint-staged": "^8.2.0", | |||
| "mocha": "^6.1.4", | |||
| "npm-run-all": "^4.1.5", | |||
| "prettier": "^1.18.2", | |||
| "prettier": "~1.18.2", | |||
There was a problem hiding this comment.
Build was failing with the resolved version of 1.19.2 so keeping it at 1.18.x until we upgrade prettier/eslint to latest
jasonmit
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for handling binary data.
Motivation and Context
#183
Types of Changes
Checklist