Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Legacy persisters and adapters should register #325

Merged
merged 1 commit into from
Apr 20, 2020
Merged

fix: Legacy persisters and adapters should register #325

merged 1 commit into from
Apr 20, 2020

Conversation

jasonmit
Copy link
Contributor

Related to #324

@jasonmit jasonmit force-pushed the u/jasonmit/fix-legacy-adapters-persisters branch from e8b2547 to 5f2a630 Compare April 19, 2020 20:35
@jasonmit jasonmit mentioned this pull request Apr 19, 2020
Closed
9 tasks
@jasonmit jasonmit force-pushed the u/jasonmit/fix-legacy-adapters-persisters branch from 5f2a630 to af373d9 Compare April 19, 2020 20:41
@jasonmit jasonmit requested a review from offirgolan April 19, 2020 20:41
@jasonmit jasonmit force-pushed the u/jasonmit/fix-legacy-adapters-persisters branch 2 times, most recently from 5537b61 to d528b07 Compare April 19, 2020 20:45
offirgolan
offirgolan reviewed Apr 20, 2020
View reviewed changes
packages/@pollyjs/utils/src/utils/id-of-factory.js Outdated
@@ -0,0 +1,13 @@
export function idOfFactory(Factory) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts of renaming this to getFactoryId?

packages/@pollyjs/utils/src/utils/id-of-factory.js Outdated
return Factory.name;
}

export default idOfFactory;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the need to re-export?

@jasonmit jasonmit force-pushed the u/jasonmit/fix-legacy-adapters-persisters branch from ed20676 to 0377313 Compare April 20, 2020 18:56
@jasonmit jasonmit merged commit 8fd4d19 into master Apr 20, 2020
@jasonmit jasonmit deleted the u/jasonmit/fix-legacy-adapters-persisters branch April 20, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offirgolan offirgolan offirgolan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonmit @offirgolan