fix: Improve abort handling #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offirgolan
commented
Mar 23, 2020
jasonmit
reviewed
Mar 23, 2020
| if (xhr.aborted) { | ||
| pollyRequest.abort(); | ||
| } else { | ||
| xhr.addEventListener('abort', () => pollyRequest.abort()); |
There was a problem hiding this comment.
General comment that applies to these abort event listeners, we should clean these event listeners up when the request is complete or aborted.
jasonmit
approved these changes
Mar 23, 2020
jasonmit
approved these changes
Mar 25, 2020
|
Still need to add tests for the node-http-adapter but a couple of things have come up so I'll try to finish up this PR by the end of the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve overall abort handling across the adapters.
Motivation and Context
Resolves #316.
Types of Changes
Checklist