Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(adapter-node-http): Use requestBodyBuffers to parse body #304

Merged
merged 1 commit into from
Jan 30, 2020
Merged

fix(adapter-node-http): Use requestBodyBuffers to parse body #304

merged 1 commit into from
Jan 30, 2020

Conversation

brandon-leapyear
Copy link
Contributor

@brandon-leapyear brandon-leapyear commented Jan 30, 2020 •
edited
Loading

✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨

Description

Use requestBodyBuffers to parse body.

Unsure if I need to add/change any tests

Motivation and Context

See #303 (comment)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My code follows the code style of this project.
  • My commits and the title of this PR follow the Conventional Commits Specification.
  • I have read the contributing guidelines.

@brandon-leapyear brandon-leapyear mentioned this pull request Jan 30, 2020
Closed
9 tasks
@offirgolan offirgolan changed the title fix: Use requestBodyBuffers to parse body fix(adapter-node-http): Use requestBodyBuffers to parse body Jan 30, 2020
@offirgolan offirgolan merged commit 113fec5 into Netflix:master Jan 30, 2020
@offirgolan offirgolan added 📦 adapter-node-http bug 🐞 Something isn't working labels Jan 30, 2020
@offirgolan
Copy link
Collaborator

Released with v4.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐞 Something isn't working 📦 adapter-node-http
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandon-leapyear @offirgolan