fix(core): Strict null query param handling #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps differentiated between `?foo` and `?foo=`
|
@jasonmit my only concern here is that this will generate new request ids. Not sure if this warrants being labeled as a breaking change or not. |
|
I'd say bugfix. It don't believe it will impact too many, let me know if my assumption is wrong |
jasonmit
approved these changes
Jan 29, 2020
|
Linking to the qs documentation: https://github.com/ljharb/qs#handling-of-null-values |
|
Released with |
|
Thank you this is working for us now with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This helps differentiated between
?fooand?foo=query params.Motivation and Context
Resolves #301.
Types of Changes
Checklist