fix(core): Disconnect from all adapters when pause is called
#291
Conversation
BREAKING CHANGE: Calling `polly.pause()` will now disconnect from all connected adapters instead of setting the mode to passthrough. Calling `polly.play()` will reconnect to the disconnected adapters before pause was called.
| @@ -256,23 +271,35 @@ describe('Unit | Polly', function() { | |||
| }); | |||
|
|
|||
| it('.pause()', async function() { | |||
There was a problem hiding this comment.
Should add a test asserting on the behavior of _order when a pause and play occurs with requests in between. Will prevent a regression but also solidify expected behavior.
|
Side note: should note this is a breaking change in the commit msg |
.travis.yml
Outdated
| @@ -17,7 +17,7 @@ before_install: | |||
| - export PATH=$HOME/.yarn/bin:$PATH | |||
|
|
|||
| install: | |||
| - yarn install --no-lockfile --non-interactive | |||
| - yarn install --frozen-lockfile --non-interactive | |||
There was a problem hiding this comment.
I think we want to keep this to ensure polly still works with all the latest deps. Otherwise, we won't pick up on breaks until they're reported.
It makes CI pipeline more fragile but it's important to see those breaks.
There was a problem hiding this comment.
Agreed. It looks like node semver v7 is no longer supporting node 8 which is breaking our node 8 build.
Node 8 is EOL as of this year, should we drop support as well? I suspect more and more packages will be doing the same.
There was a problem hiding this comment.
Sounds good, I'll address in a follow up PR as this is unrelated.
This reverts commit 35d93f5.
Description
Calling
polly.pause()will now disconnect from all connected adapters instead of setting the mode to passthrough. Callingpolly.play()will reconnect to the disconnected adapters before pause was called.Motivation and Context
Resolves #285.
Types of Changes
Checklist