Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(adapter-node-http): Bump nock version to correctly handle responses #289

Merged
merged 1 commit into from
Jan 8, 2020
Merged

fix(adapter-node-http): Bump nock version to correctly handle responses #289

merged 1 commit into from
Jan 8, 2020

Conversation

offirgolan
Copy link
Collaborator

Motivation and Context

See #278.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My code follows the code style of this project.
  • My commits and the title of this PR follow the Conventional Commits Specification.
  • I have read the contributing guidelines.

@offirgolan offirgolan merged commit 8d0ae97 into master Jan 8, 2020
@offirgolan offirgolan deleted the bump-nock-version branch January 8, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependency issue 📦 adapter-node-http
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@offirgolan