fix(ember): BREAKING load polly config for ember by its own module #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmit
commented
Dec 10, 2019
|
|
||
| const { assign } = Object; | ||
| function determineEnv() { |
There was a problem hiding this comment.
Lifted from a previous method I wrote for ember-cli-dotenv:
https://github.com/fivetanley/ember-cli-dotenv/blob/master/index.js#L49-L68
It's been reliable for awhile and until the upstream bug is resolved there's no elegant way around it.
jasonmit
commented
Dec 10, 2019
| @@ -32,7 +32,7 @@ const { Server } = require('@pollyjs/node-server'); | |||
| const server = new Server({ | |||
| quiet: true, | |||
| port: 4000, | |||
| apiNamespace: '/pollyjs' | |||
| apiNamespace: '/polly' | |||
There was a problem hiding this comment.
Just making the docs references consistent since they all sort of vary.
offirgolan
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we rely on
included()to be called and read all config options fromapp.optionsderived fromember-cli-build.jsat the time the app is built. This strategy is no longer reliable since you can run tests against previously built assets which meansincludedis never called nor isapp.optionsavailable since the app isn't being built.Instead, I introduced
config/polly.jsand rely upon my own function to determine what the env is (see: ember-cli/ember-cli#8922 as to why I had to go with that approach).This is a breaking change for @pollyjs/ember so we'll need to release a new major for the addon.
Resolves #276