Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Filter requests matched by a route handler #189

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

offirgolan
Copy link
Collaborator

Description

Filter requests matched by the route handler with a predicate callback function.

The callback will receive the request as an argument. Return true to match the request, false otherwise.

Multiple filters can be chained together. They must all return true for the route handler to match the given request.

Motivation and Context

This can be useful when trying to match a request by a part of the url (e.g. a query param), a header,
and/or parts of the request body.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My code follows the code style of this project.
  • My commits and the title of this PR follow the Conventional Commits Specification.
  • I have read the contributing guidelines.

@offirgolan offirgolan added enhancement ✨ New feature or request 📦 core labels Feb 26, 2019
@offirgolan offirgolan requested a review from jasonmit February 26, 2019 07:47
@offirgolan offirgolan merged commit 5d57c32 into master Feb 26, 2019
@offirgolan offirgolan deleted the route-handler-filter branch February 26, 2019 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request 📦 core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants