Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Add removeHeader, removeHeaders, and allow empty headers #176

Merged
merged 4 commits into from
Feb 1, 2019
Merged

feat(core): Add removeHeader, removeHeaders, and allow empty headers #176

merged 4 commits into from
Feb 1, 2019

Conversation

offirgolan
Copy link
Collaborator

@offirgolan offirgolan commented Jan 31, 2019 •
edited
Loading

  1. Add removeHeader and removeHeaders API. This is a lot more intuitive than `setHeader('Content-Type', null).
  2. Support setting empty header values as the Host header can be an empty string.
  3. Support for deleting a header property via delete header[prop] where prop can be any case.

@offirgolan offirgolan changed the title feat(core): Add removeHeader, removeHeaders, and allow empty headers feat(core): Add removeHeader, removeHeaders, and allow empty headers Jan 31, 2019
@offirgolan offirgolan requested a review from jasonmit January 31, 2019 22:02
@offirgolan offirgolan mentioned this pull request Jan 31, 2019
Closed
@offirgolan offirgolan merged commit 1dfae5a into master Feb 1, 2019
@offirgolan offirgolan deleted the improve-headers-api branch February 1, 2019 18:17
@feinoujc feinoujc mentioned this pull request Feb 21, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmit jasonmit jasonmit approved these changes

Assignees
No one assigned
Labels
📦 core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@offirgolan @jasonmit