feat(adapter-node-http): Use nock under the hood instead of custom implementation
#166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmit
reviewed
Jan 27, 2019
...er_1543864754/http_3378792613/should-call-all-the-life-cycle-events_2199659288/recording.har
Show resolved
Hide resolved
|
@offirgolan would you mind publishing the latest changes on master? I'd like to beta test this unmerged PR but am having dependency issues since the adapter logic changed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reasoning behind this drastic change in implementation is that although we were able to override request methods once it was created, we did not take into account the socket creation that was setup in the initialization of the ClientRequest. To be able to modify that logic, we would have to mock out the entire ClientRequest class which nock already does and does it well.