Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Lint other filetypes with prettier #152

Merged
merged 3 commits into from
Jan 8, 2019
Merged

Conversation

vikr01
Copy link
Contributor

@vikr01 vikr01 commented Dec 30, 2018

prettier supports linting for various other languages besides javascript.

  • Use prettier to autofix json, md, html, yml, and css files since they're all used in this repo
    • Used during precommit
    • Used in postlint:fix script that occurs after the lint:fix script
  • Change .prettierrc to .prettierrc.json so it can be linted (could also keep it as .prettierrc and use the overrides option in the config)
  • Include dotfiles in lint-staged since they aren't be default
  • Don't lint package.json with prettier since it gets changed by package managers.

Copy link
Collaborator

@offirgolan offirgolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR @vikr01. I've noted a couple of files that should be ignored from linting altogether as they are auto generated.

packages/@pollyjs/adapter-fetch/CHANGELOG.md Outdated Show resolved Hide resolved
packages/@pollyjs/ember/tests/index.html Outdated Show resolved Hide resolved
packages/@pollyjs/ember/tests/dummy/app/index.html Outdated Show resolved Hide resolved
@offirgolan offirgolan requested a review from jasonmit January 8, 2019 17:32
@jasonmit jasonmit merged commit 78d1af8 into Netflix:master Jan 8, 2019
@vikr01 vikr01 deleted the linting branch January 13, 2019 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants