Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add an onIdentifyRequest hook to allow adapter level serialization #140

Merged
merged 5 commits into from
Nov 27, 2018

Conversation

offirgolan
Copy link
Collaborator

@offirgolan offirgolan commented Nov 25, 2018

This PR adds an onIdentifyRequest hook for all adapters which will allow them to each handle the serialization of certain identifiers (mostly the request body). I've created a blob, formData, and buffer serializer that can be used or an adapter may choose to implement its own. By default, all 3 will be run as they are each safe to be executed in both environments.

@offirgolan offirgolan added the enhancement ✨ New feature or request label Nov 25, 2018
@offirgolan offirgolan requested a review from jasonmit November 25, 2018 02:33
@offirgolan offirgolan merged commit 548002c into master Nov 27, 2018
@offirgolan offirgolan deleted the adapter-identify-request-hook branch November 27, 2018 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants