fix: Puppeteer CORS request matching #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offirgolan
commented
Sep 15, 2018
| @@ -231,6 +233,7 @@ export default class PuppeteerAdapter extends Adapter { | |||
| await response.text() | |||
| ); | |||
| } catch (error) { | |||
| console.error(error); | |||
There was a problem hiding this comment.
Print out the error so its displayed in the test runners.
jasonmit
approved these changes
Sep 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preflight requests should not be matched to a pollyRequest since Polly should never actually be aware of such a request.