fix: Allow 204 responses without a body #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that 204 responses using fetch attempt to call `new Response` with an empty string as a body, which is illegal and blows hard. The body must be null.
|
I'll add a test or two before versioning. Thanks! |
|
Yeah, I tried for 20m to find a good way to test it but I wasn't very sure how to do it. |
jasonmit
added a commit
that referenced
this pull request
Aug 21, 2018
jasonmit
added a commit
that referenced
this pull request
Aug 22, 2018
jasonmit
added a commit
that referenced
this pull request
Aug 22, 2018
jasonmit
added a commit
that referenced
this pull request
Aug 22, 2018
jasonmit
added a commit
that referenced
this pull request
Aug 22, 2018
jasonmit
added a commit
that referenced
this pull request
Aug 22, 2018
jasonmit
added a commit
that referenced
this pull request
Aug 22, 2018
jasonmit
added a commit
that referenced
this pull request
Aug 22, 2018
jasonmit
added a commit
that referenced
this pull request
Aug 22, 2018
jasonmit
added a commit
that referenced
this pull request
Aug 22, 2018
jasonmit
added a commit
that referenced
this pull request
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that 204 responses using fetch attempt to call
new Responsewith an empty string as a body, which is illegal and blows hard. The body
must be null.