fix: Puppeteer 1.7.0 support #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmit
commented
Aug 19, 2018
| requestResourceTypes: ['xhr', 'fetch'] | ||
|
|
||
| /* NOTE: `"other" is needed as of puppeteer 1.7.0 to capture the passthrough request */ | ||
| requestResourceTypes: ['xhr', 'fetch', 'other'] |
There was a problem hiding this comment.
As of Puppeteer 1.7.0, the resource type of the fetch we run in the browser gets triggered as "other" for a resource type.
jasonmit
force-pushed
the
u/jasonmit/puppeteer-1.7.0
branch
from
89742cf to
b449cfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #93 also refactored to avoid mutating the puppeteer object passed in to Polly.