fix(core): Strict null query param handling (#302)

This helps differentiated between `?foo` and `?foo=` query params.
Netflix · Jan 29, 2020 · 5cf70aa · 5cf70aa
1 parent 7a3c06e
commit 5cf70aa
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/packages/@pollyjs/utils/src/utils/url.js b/packages/@pollyjs/utils/src/utils/url.js
@@ -9,12 +9,17 @@ function parseQuery(query, options) {
   return qs.parse(query, {
     plainObjects: true,
     ignoreQueryPrefix: true,
+    strictNullHandling: true,
     ...options
   });
 }
 
 function stringifyQuery(obj, options = {}) {
-  return qs.stringify(obj, { addQueryPrefix: true, ...options });
+  return qs.stringify(obj, {
+    addQueryPrefix: true,
+    strictNullHandling: true,
+    ...options
+  });
 }
 
 /**

diff --git a/packages/@pollyjs/utils/tests/unit/utils/url-test.js b/packages/@pollyjs/utils/tests/unit/utils/url-test.js
@@ -19,6 +19,7 @@ describe('Unit | Utils | URL', function() {
   it('should correctly parse query params', function() {
     [
       ['', {}],
+      ['a&b=', { a: null, b: '' }],
       ['foo=bar', { foo: 'bar' }],
       ['a[]=1&a[]=2', { a: ['1', '2'] }],
       ['a[1]=1&a[0]=2', { a: ['2', '1'] }],
@@ -33,6 +34,7 @@ describe('Unit | Utils | URL', function() {
     [
       // Query string will be undefined but we decode it in the assertion
       [{}, decode(undefined)],
+      [{ a: null, b: '' }, 'a&b='],
       [{ foo: 'bar' }, 'foo=bar'],
       [{ a: ['1', '2'] }, 'a[0]=1&a[1]=2'],
       [{ foo: { bar: { baz: '1' } } }, 'foo[bar][baz]=1']