Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for required custom_fields overwrite existing data #1860

Closed
bdlamprecht opened this issue Feb 2, 2018 · 2 comments
Closed
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@bdlamprecht
Copy link
Contributor

Issue type

[ ] Feature request
[X] Bug report
[ ] Documentation

Environment

  • Python version: 3.6.4
  • NetBox version: 2.2.9

Description

I didn't do a complete test to see if this was limited only to the device model, but that is where I originally saw the error.

When doing a bulk update to devices, you are presented with the following window:

image

As you can see, the default value is pre-populated for the custom_fields that are required.
My example uses N/A for both template_name and template_version.

If you change any field here (platform or status or type), it will overwrite any accurate information stored in those custom_fields.

In my opinion, this is undesired outcome as most likely you won't want to have to remove the pre-populated values every time you do a bulk edit.

@bdlamprecht
Copy link
Contributor Author

I just verified that this was not the case in v2.2.8 (default and required values for custom_fields weren't pre-populated).

@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application status: accepted This issue has been accepted for implementation labels Feb 3, 2018
@jeremystretch
Copy link
Member

I don't think this changed in v2.2.9. It seems to happen in v2.2.8 as well, though I didn't check any further back. At any rate, this should be fixed in 594ef71. If you still have problems comment here and I'll re-open this for further investigation.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

2 participants