Fixes #16781 adds an 100Base SFP interface #16809
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comment so maintainer is able to assign. |
RobertH1993
changed the title
jeremystretch
requested changes
Jul 8, 2024
| @@ -825,6 +825,7 @@ class InterfaceTypeChoices(ChoiceSet): | |||
| # Ethernet | |||
| TYPE_100ME_FX = '100base-fx' | |||
| TYPE_100ME_LFX = '100base-lfx' | |||
| TYPE_100ME_FX_SFP = '100base-fx-sfp' | |||
There was a problem hiding this comment.
Suggested change
| TYPE_100ME_FX_SFP = '100base-fx-sfp' | |
| TYPE_100ME_SFP = '100base-x-sfp' |
| @@ -1000,6 +1002,7 @@ class InterfaceTypeChoices(ChoiceSet): | |||
| ( | |||
| (TYPE_1GE_GBIC, 'GBIC (1GE)'), | |||
| (TYPE_1GE_SFP, 'SFP (1GE)'), | |||
|
|
|||
There was a problem hiding this comment.
Remove errant newline.
Suggested change
| @@ -985,6 +986,7 @@ class InterfaceTypeChoices(ChoiceSet): | |||
| ( | |||
| (TYPE_100ME_FX, '100BASE-FX (10/100ME FIBER)'), | |||
| (TYPE_100ME_LFX, '100BASE-LFX (10/100ME FIBER)'), | |||
| (TYPE_100ME_FX_SFP, '100BASE-FX-SFP (10/100ME FIBER)'), | |||
There was a problem hiding this comment.
The SFP interface type does not imply a specific medium (e.g. FX), just the line rate. Also, this needs to be moved to the "Ethernet (modular)" group as it is modular in nature.
Suggested change
| (TYPE_100ME_FX_SFP, '100BASE-FX-SFP (10/100ME FIBER)'), | |
| (TYPE_100ME_SFP, 'SFP (100ME)'), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16781
Adds the requested SFP type