Skip to content

Commit e1b2b4b

Browse files
Fixes #17676: Fix support for module bay creation when bulk importing module types (#19311)
1 parent f711e66 commit e1b2b4b

File tree

3 files changed

+16
-1
lines changed

3 files changed

+16
-1
lines changed

netbox/dcim/forms/object_import.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ class ModuleBayTemplateImportForm(forms.ModelForm):
159159
class Meta:
160160
model = ModuleBayTemplate
161161
fields = [
162-
'device_type', 'name', 'label', 'position', 'description',
162+
'device_type', 'module_type', 'name', 'label', 'position', 'description',
163163
]
164164

165165

netbox/dcim/tests/test_views.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1205,6 +1205,13 @@ def test_import_objects(self):
12051205
- name: Front Port 3
12061206
type: 8p8c
12071207
rear_port: Rear Port 3
1208+
module-bays:
1209+
- name: Module Bay 1
1210+
position: 1
1211+
- name: Module Bay 2
1212+
position: 2
1213+
- name: Module Bay 3
1214+
position: 3
12081215
"""
12091216

12101217
# Create the manufacturer
@@ -1222,6 +1229,7 @@ def test_import_objects(self):
12221229
'dcim.add_interfacetemplate',
12231230
'dcim.add_frontporttemplate',
12241231
'dcim.add_rearporttemplate',
1232+
'dcim.add_modulebaytemplate',
12251233
)
12261234

12271235
form_data = {
@@ -1276,6 +1284,11 @@ def test_import_objects(self):
12761284
self.assertEqual(fp1.rear_port, rp1)
12771285
self.assertEqual(fp1.rear_port_position, 1)
12781286

1287+
self.assertEqual(module_type.modulebaytemplates.count(), 3)
1288+
mb1 = ModuleBayTemplate.objects.first()
1289+
self.assertEqual(mb1.name, 'Module Bay 1')
1290+
self.assertEqual(mb1.position, '1')
1291+
12791292
def test_export_objects(self):
12801293
url = reverse('dcim:moduletype_list')
12811294
self.add_permissions('dcim.view_moduletype')

netbox/dcim/views.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1508,6 +1508,7 @@ class ModuleTypeImportView(generic.BulkImportView):
15081508
'dcim.add_interfacetemplate',
15091509
'dcim.add_frontporttemplate',
15101510
'dcim.add_rearporttemplate',
1511+
'dcim.add_modulebaytemplate',
15111512
]
15121513
queryset = ModuleType.objects.all()
15131514
model_form = forms.ModuleTypeImportForm
@@ -1519,6 +1520,7 @@ class ModuleTypeImportView(generic.BulkImportView):
15191520
'interfaces': forms.InterfaceTemplateImportForm,
15201521
'rear-ports': forms.RearPortTemplateImportForm,
15211522
'front-ports': forms.FrontPortTemplateImportForm,
1523+
'module-bays': forms.ModuleBayTemplateImportForm,
15221524
}
15231525

15241526
def prep_related_object_data(self, parent, data):

0 commit comments

Comments
 (0)