Fix CSVModelMultipleChoiceField.clean assuming all values are str/None

jnovinger · jeremystretch · commit b31da39c4a35 · 2025-04-28T08:41:27.000-04:00
diff --git a/netbox/utilities/forms/fields/csv.py b/netbox/utilities/forms/fields/csv.py
@@ -79,7 +79,8 @@ class CSVModelMultipleChoiceField(forms.ModelMultipleChoiceField):
     }
 
     def clean(self, value):
-        value = value.split(',') if value else []
+        if not isinstance(value, list):
+            value = value.split(',') if value else []
         return super().clean(value)
 
 

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,8 @@ class CSVModelMultipleChoiceField(forms.ModelMultipleChoiceField):`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`def clean(self, value):`
`82`		`- value = value.split(',') if value else []`
	`82`	`+ if not isinstance(value, list):`
	`83`	`+ value = value.split(',') if value else []`
`83`	`84`	`return super().clean(value)`
`84`	`85`
`85`	`86`