Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchemaDirectiveVisitor was removed in: @graphql-tools/utils #8481

Closed
3 of 15 tasks
lukasholzer opened this issue Nov 1, 2021 · 1 comment
Closed
3 of 15 tasks

SchemaDirectiveVisitor was removed in: @graphql-tools/utils #8481

lukasholzer opened this issue Nov 1, 2021 · 1 comment
Labels
needs triage This issue has not been looked into

Comments

@lukasholzer
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

Using the snippet from the documentation about custom graphql schema directives:
https://docs.nestjs.com/graphql/directives#custom-directives

does not work anymore as @graphql-tools/utils has removed the SchemaDirectiveVisitor

CleanShot 2021-11-01 at 12 43 51

Minimum reproduction code

https://github.com/nestjs/graphql/blob/master/tests/graphql-federation/posts-service/posts/upper.directive.ts

Steps to reproduce

go to the tests and update graphql-tools to the latest version: @graphql-tools/utils": "^8.5.1

Expected behavior

The example on the documentation should work

Package

  • I don't know. Or some 3rd-party package
  • @nestjs/common
  • @nestjs/core
  • @nestjs/microservices
  • @nestjs/platform-express
  • @nestjs/platform-fastify
  • @nestjs/platform-socket.io
  • @nestjs/platform-ws
  • @nestjs/testing
  • @nestjs/websockets
  • Other (see below)

Other package

@nestjs/graphql

NestJS version

8.1.2

Packages versions

    "@nestjs/common": "^8.1.2",
    "@nestjs/config": "^1.0.2",
    "@nestjs/core": "^8.1.2",
    "@nestjs/graphql": "^9.1.1",
    "@nestjs/mapped-types": "1.0.0",
    "@nestjs/microservices": "^8.1.2",
    "@nestjs/mongoose": "^9.0.1",
    "@nestjs/platform-fastify": "^8.1.2",

Node.js version

16.0.0

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@lukasholzer lukasholzer added the needs triage This issue has not been looked into label Nov 1, 2021
@kamilmysliwiec
Copy link
Member

image

@nestjs nestjs locked and limited conversation to collaborators Nov 2, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs triage This issue has not been looked into
Projects
None yet
Development

No branches or pull requests

2 participants