Hi there.
Thanks for your interest in Parsley and your will to contribute. You're welcome!
Here are a few simple rules you'll have to follow in order to ease code reviews, discussions and PR merging.
-
You MUST follow Parsley coding standard. It basically follows these popular rules except that functions are followed by one space on Parsley. Use two spaces as tabs.
-
You MUST write / update tests for each code contribution you do
-
You MUST commit a passing test-suite
-
You SHOULD write documentation
Please, write commit messages that make sense, and rebase your branch before submitting your Pull Request.
One may ask you to squash your
commits
too. This is used to "clean" your Pull Request before merging it (we don't want
commits such as fix tests
, fix 2
, fix 3
, etc.).
Also, while creating your Pull Request on GitHub, you MUST write a description which gives the context and/or explains why you are creating it.
Thank you!
Inspired by http://williamdurand.fr/2013/07/04/on-open-sourcing-libraries/