feat: Do not use inline label for settings toggle button

nervosnetwork · Aug 4, 2019 · 75eded1 · 75eded1
1 parent 2f6e2b1
commit 75eded1
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 7 deletions.
diff --git a/packages/neuron-ui/src/components/GeneralSetting/index.tsx b/packages/neuron-ui/src/components/GeneralSetting/index.tsx
@@ -13,11 +13,10 @@ const GeneralSetting = ({ settings: { showAddressBook }, dispatch }: React.Props
   return (
     <Stack tokens={{ childrenGap: 15 }}>
       <Toggle
-        inlineLabel
         checked={showAddressBook}
         label={t('settings.general.display-address-book-in-the-navbar')}
-        onText={t('settings.general.show')}
-        offText={t('settings.general.hide')}
+        onText={t('common.toggle.on')}
+        offText={t('common.toggle.off')}
         onChange={onToggle}
       />
     </Stack>

diff --git a/packages/neuron-ui/src/locales/en.json b/packages/neuron-ui/src/locales/en.json
@@ -129,7 +129,7 @@
         "network": "Network"
       },
       "general": {
-        "display-address-book-in-the-navbar": "Display the address book in the navigation",
+        "display-address-book-in-the-navbar": "Show the address book",
         "show": "Show",
         "hide": "Hide"
       },
@@ -194,7 +194,11 @@
       "or": "or",
       "confirm": "Confirm",
       "cancel": "Cancel",
-      "save": "Save"
+      "save": "Save",
+      "toggle": {
+        "on": "On",
+        "off": "Off"
+      }
     },
     "notification-panel": {
       "title": "Notifications"

diff --git a/packages/neuron-ui/src/locales/zh.json b/packages/neuron-ui/src/locales/zh.json
@@ -129,7 +129,7 @@
         "network": "网络"
       },
       "general": {
-        "display-address-book-in-the-navbar": "导航栏中显示地址簿",
+        "display-address-book-in-the-navbar": "显示地址簿",
         "show": "显示",
         "hide": "隐藏"
       },
@@ -194,7 +194,11 @@
       "or": "或",
       "confirm": "确认",
       "cancel": "取消",
-      "save": "保存"
+      "save": "保存",
+      "toggle": {
+        "on": "开",
+        "off": "关"
+      }
     },
     "notification-panel": {
       "title": "通知中心"