This repository was archived by the owner on Sep 13, 2022. It is now read-only.
perf(state): add state cache for trieDB #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 6, 2020 19:42
|
Add the benchmark of the executor? You need to make sure that it create a new MPT each time. |
yejiayu
reviewed
Aug 7, 2020
yejiayu
suggested changes
Aug 7, 2020
yejiayu
reviewed
Aug 7, 2020
|
Can you show a result of perf to this PR descriptions？ |
yejiayu
suggested changes
Aug 10, 2020
| use rocksdb::{Options, WriteBatch, DB}; | ||
|
|
||
| use common_apm::metrics::storage::{on_storage_get_state, on_storage_put_state}; | ||
| use protocol::{ProtocolError, ProtocolErrorKind, ProtocolResult}; | ||
|
|
||
| const RAND_SEED: u64 = 49999; |
There was a problem hiding this comment.
Does it have any relationship with cache length?
|
/lgtm |
|
/hold |
|
/hold cancel |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yejiayu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implement an approximately fixed size cache through HashMap. It caches the data used in the latest block, and it will be flushed when committing a block. The size of the cache is 2000, however, this does not mean that it can only store 2000 data. When the data in the cache is more than 2000 when the cache is refreshed, it will be randomly deleted to 2000. The random seed is the largest prime number within 50000, 49999.
Which issue(s) this PR fixes:
Fixes #
Which docs this PR relation:
Ref nervosnetwork/muta-docs#55
Which toolchain this PR adaption:
No Breaking Change
Special notes for your reviewer: