Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tweak max_ancestors_count #4487

Conversation

zhangsoledad
Copy link
Member

What problem does this PR solve?

The current limitation of max_ancestors is too small and affects many application scenarios. After retesting, we have adjusted max_ancestors to a more appropriate yet safe value.

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

Title Only: Include only the PR title in the release note.

@zhangsoledad zhangsoledad requested a review from a team as a code owner June 20, 2024 06:59
@zhangsoledad zhangsoledad requested review from quake and removed request for a team June 20, 2024 06:59
eval-exec
eval-exec previously approved these changes Jun 20, 2024
quake
quake previously approved these changes Jun 20, 2024
@quake quake enabled auto-merge June 20, 2024 07:01
@chenyukang
Copy link
Collaborator

I remember this case also need to fix: test/src/specs/tx_pool/limit.rs.

@zhangsoledad zhangsoledad dismissed stale reviews from quake and eval-exec via 6619344 June 20, 2024 08:58
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/tweak_max_ancestors_count branch from fe98cff to 6619344 Compare June 20, 2024 08:58
@zhangsoledad zhangsoledad requested review from quake and eval-exec June 20, 2024 08:59
@quake quake added this pull request to the merge queue Jun 20, 2024
Merged via the queue into nervosnetwork:develop with commit 247befe Jun 20, 2024
32 checks passed
@zhangsoledad zhangsoledad deleted the zhangsoledad/tweak_max_ancestors_count branch June 21, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants