Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade SDKs to support CKB v0.106.0 #3726

Closed
doitian opened this issue Nov 25, 2022 · 4 comments
Closed

Upgrade SDKs to support CKB v0.106.0 #3726

doitian opened this issue Nov 25, 2022 · 4 comments
Assignees
@quake
Labels
t:enhancement Type: Feature, refactoring.

Comments

@doitian
Copy link
Member

doitian commented Nov 25, 2022 •
edited
Loading

RPC changes:

https://github.com/nervosnetwork/ckb/tree/develop/rpc#method-estimate_cycles
https://github.com/nervosnetwork/ckb/tree/develop/rpc#method-get_fee_rate_statics
https://github.com/nervosnetwork/ckb/tree/develop/rpc#method-get_transaction

Related #3710
@doitian doitian added the t:enhancement Type: Feature, refactoring. label Nov 25, 2022
@gpBlockchain
Copy link
Collaborator

compare 1.0.5~106

@liuck8080
Copy link

liuck8080 commented Dec 1, 2022 •
edited
Loading

according to the code, get_fee_rate_statics, if the target is odd, and it's can be bigger than 101, should it be a problem?

@liuck8080 liuck8080 mentioned this issue Dec 2, 2022
Merged
@liuck8080 liuck8080 mentioned this issue Dec 13, 2022
Closed
@liuck8080
Copy link

according to the code, get_fee_rate_statics, if the target is odd, and it's can be bigger than 101, should it be a problem?

new issue create for this problem: #3755

@gpBlockchain
Copy link
Collaborator

gpBlockchain commented Dec 14, 2022 •
edited
Loading

get_fee_rate_statics： - 0c94c63

@homura homura mentioned this issue Dec 20, 2022
Closed
@liuck8080 liuck8080 mentioned this issue Dec 21, 2022
Merged
@doitian doitian closed this as completed Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quake quake

Labels
t:enhancement Type: Feature, refactoring.
Projects
CKB Kanban
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@quake @doitian @liuck8080 @gpBlockchain