Make PixelSampler the depth-nerfacto default #3454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default pixel sampler for
depth-nerfacto
isPairPixelSampler
. However, this is very slow due to mask erosion (so slow that it is basically unusable). I managed to speed it up a little here #3452. However, it is still much more efficient to usePixelSampler
. Moreover,PairPixelSampler
is only needed when usingSPARSENERF_RANKING
as the depth loss, but the default value isDS_NERF
, which doesn't requirePairPixelSampler
. Hence, with the default depth loss, most people will be much better off withPixelSampler
instead ofPairPixelSampler
.I tested with both depth and masks using 50 images of resolution 1920x1440. Note, that
PairPixelSampler
is only slow when training with masks due to the need for mask erosion.With
PairPixelSampler
:With
PixelSampler
:Closes #3446