From 70ade42e46f3dcf0e89e4efc445650f6d6525673 Mon Sep 17 00:00:00 2001 From: Justin Kerr Date: Tue, 10 Oct 2023 17:11:36 -0700 Subject: [PATCH 1/5] fix jittering in markdown in viewer beta --- nerfstudio/viewer_beta/control_panel.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/nerfstudio/viewer_beta/control_panel.py b/nerfstudio/viewer_beta/control_panel.py index 07f556dd46..d93d335468 100644 --- a/nerfstudio/viewer_beta/control_panel.py +++ b/nerfstudio/viewer_beta/control_panel.py @@ -270,10 +270,9 @@ def update_step(self, step): step: the train step to set the model to """ with self.viser_server.atomic(), self.stat_folder: - # TODO change to a .value call instead of remove() and add, this makes it jittery with self.viser_server.atomic(): self.markdown.remove() - self.markdown = self.viser_server.add_gui_markdown(f"Step: {step}") + self.markdown.content = f"Step: {step}" def update_output_options(self, new_options: List[str]): """ From 622342cdceaa2b01ffc7518c2bf8542c687f5a23 Mon Sep 17 00:00:00 2001 From: Justin Kerr Date: Tue, 10 Oct 2023 17:12:21 -0700 Subject: [PATCH 2/5] Revert "fix jittering in markdown in viewer beta" This reverts commit 70ade42e46f3dcf0e89e4efc445650f6d6525673. --- nerfstudio/viewer_beta/control_panel.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/nerfstudio/viewer_beta/control_panel.py b/nerfstudio/viewer_beta/control_panel.py index d93d335468..07f556dd46 100644 --- a/nerfstudio/viewer_beta/control_panel.py +++ b/nerfstudio/viewer_beta/control_panel.py @@ -270,9 +270,10 @@ def update_step(self, step): step: the train step to set the model to """ with self.viser_server.atomic(), self.stat_folder: + # TODO change to a .value call instead of remove() and add, this makes it jittery with self.viser_server.atomic(): self.markdown.remove() - self.markdown.content = f"Step: {step}" + self.markdown = self.viser_server.add_gui_markdown(f"Step: {step}") def update_output_options(self, new_options: List[str]): """ From d275951ecc492ba3a6a5941564211b2361d50ac5 Mon Sep 17 00:00:00 2001 From: Justin Kerr Date: Tue, 10 Oct 2023 17:13:12 -0700 Subject: [PATCH 3/5] fix markdown jitter in viewer --- nerfstudio/viewer_beta/control_panel.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nerfstudio/viewer_beta/control_panel.py b/nerfstudio/viewer_beta/control_panel.py index 07f556dd46..4f0465a684 100644 --- a/nerfstudio/viewer_beta/control_panel.py +++ b/nerfstudio/viewer_beta/control_panel.py @@ -273,7 +273,7 @@ def update_step(self, step): # TODO change to a .value call instead of remove() and add, this makes it jittery with self.viser_server.atomic(): self.markdown.remove() - self.markdown = self.viser_server.add_gui_markdown(f"Step: {step}") + self.markdown.content = f"Step: {step}" def update_output_options(self, new_options: List[str]): """ From 670479ade911720dce33b871a1c4e14d76fefee4 Mon Sep 17 00:00:00 2001 From: Justin Kerr Date: Tue, 10 Oct 2023 17:13:36 -0700 Subject: [PATCH 4/5] fix --- nerfstudio/viewer_beta/control_panel.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/nerfstudio/viewer_beta/control_panel.py b/nerfstudio/viewer_beta/control_panel.py index 4f0465a684..7161816941 100644 --- a/nerfstudio/viewer_beta/control_panel.py +++ b/nerfstudio/viewer_beta/control_panel.py @@ -269,11 +269,7 @@ def update_step(self, step): Args: step: the train step to set the model to """ - with self.viser_server.atomic(), self.stat_folder: - # TODO change to a .value call instead of remove() and add, this makes it jittery - with self.viser_server.atomic(): - self.markdown.remove() - self.markdown.content = f"Step: {step}" + self.markdown.content = f"Step: {step}" def update_output_options(self, new_options: List[str]): """ From 8dd9fd8c04df40f9f87505ab893a238a670c1b5d Mon Sep 17 00:00:00 2001 From: Justin Kerr Date: Tue, 10 Oct 2023 17:17:40 -0700 Subject: [PATCH 5/5] viser version --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index c041858ba3..fc2b0be03a 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -53,7 +53,7 @@ dependencies = [ "torchvision>=0.14.1", "torchmetrics[image]>=1.0.1", "typing_extensions>=4.4.0", - "viser==0.1.3", + "viser==0.1.6", "nuscenes-devkit>=1.1.1", "wandb>=0.13.3", "xatlas",