Skip to content

Commit 35f8f73

Browse files
committed
Drop support for Python 3.8, suggest 3.10 by default (and unrelated automatic formatting fixes)
1 parent 6b60855 commit 35f8f73

File tree

2 files changed

+12
-14
lines changed

2 files changed

+12
-14
lines changed

docs/quickstart/installation.md

+10-10
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@
55
::::::{tab-set}
66
:::::{tab-item} Linux
77

8-
Nerfstudio requires `python >= 3.8`. We recommend using conda to manage dependencies. Make sure to install [Conda](https://docs.conda.io/en/latest/miniconda.html) before proceeding.
8+
Nerfstudio requires `python >= 3.9`. We recommend using conda to manage dependencies. Make sure to install [Conda](https://docs.conda.io/en/latest/miniconda.html) before proceeding.
99

1010
:::::
1111
:::::{tab-item} Windows
1212

1313
:::{admonition} Note
1414
:class: info
15-
Nerfstudio on Windows is less tested and more fragile, due to way more moving parts outside of Nerfstudio's control.
16-
The instructions also tend to break over time as updates to different Windows packages happen.
17-
Installing Nerfstudio on Linux instead is recommended if you have the option.
15+
Nerfstudio on Windows is less tested and more fragile, due to way more moving parts outside of Nerfstudio's control.
16+
The instructions also tend to break over time as updates to different Windows packages happen.
17+
Installing Nerfstudio on Linux instead is recommended if you have the option.
1818
Alternatively, installing Nerfstudio under WSL2 (temporary unofficial guide [here](https://gist.github.com/SharkWipf/0a3fc1be3ea88b0c9640db6ce15b44b9), not guaranteed to work) is also an option, but this comes with its own set of caveats.
1919
:::
2020

@@ -51,15 +51,15 @@ For example:
5151
When updating, or if you close your terminal before you finish the installation and run your first `splatfacto`, you have to re-do this environment activation step.
5252
:::
5353

54-
Nerfstudio requires `python >= 3.8`. We recommend using conda to manage dependencies. Make sure to install [Conda](https://docs.conda.io/en/latest/miniconda.html) before proceeding.
54+
Nerfstudio requires `python >= 3.9`. We recommend using conda to manage dependencies. Make sure to install [Conda](https://docs.conda.io/en/latest/miniconda.html) before proceeding.
5555

5656
:::::
5757
::::::
5858

5959
## Create environment
6060

6161
```bash
62-
conda create --name nerfstudio -y python=3.8
62+
conda create --name nerfstudio -y python=3.10
6363
conda activate nerfstudio
6464
python -m pip install --upgrade pip
6565

@@ -184,15 +184,15 @@ TLDR for linux:
184184
curl -fsSL https://pixi.sh/install.sh | bash
185185
```
186186

187-
### Install Pixi Environmnent
187+
### Install Pixi Environmnent
188188
After Pixi is installed, you can run
189189
```bash
190190
git clone https://github.com/nerfstudio-project/nerfstudio.git
191191
cd nerfstudio
192192
pixi run post-install
193193
pixi shell
194194
```
195-
This will fetch the latest Nerfstudio code, install all enviroment dependencies including colmap, tinycudann and hloc, and then activate the pixi environment (similar to conda).
195+
This will fetch the latest Nerfstudio code, install all enviroment dependencies including colmap, tinycudann and hloc, and then activate the pixi environment (similar to conda).
196196
From now on, each time you want to run Nerfstudio in a new shell, you have to navigate to the nerfstudio folder and run `pixi shell` again.
197197

198198
You could also run
@@ -435,6 +435,6 @@ export PATH=$PATH:$CUDA_HOME/bin
435435

436436
**Other errors**
437437

438-
(Windows) A lot of errors on Windows can be caused by not having the Visual Studio environment loaded.
439-
If you run into errors you can't figure out, please try re-activating the Visual Studio environment (as outlined at the top of the Windows instructions on this page) and try again.
438+
(Windows) A lot of errors on Windows can be caused by not having the Visual Studio environment loaded.
439+
If you run into errors you can't figure out, please try re-activating the Visual Studio environment (as outlined at the top of the Windows instructions on this page) and try again.
440440
This activation only lasts within your current terminal session and does not extend to other terminals, but this should only be needed on first run and on updates.

pyproject.toml

+2-4
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ version = "1.1.5"
88
description = "All-in-one repository for state-of-the-art NeRFs"
99
readme = "README.md"
1010
license = { text="Apache 2.0"}
11-
requires-python = ">=3.8.0"
11+
requires-python = ">=3.9.0"
1212
classifiers = [
1313
"Development Status :: 3 - Alpha",
1414
"Programming Language :: Python",
@@ -39,9 +39,7 @@ dependencies = [
3939
"protobuf<=3.20.3,!=3.20.0",
4040
# TODO(1480) enable when pycolmap windows wheels are available
4141
# "pycolmap==0.3.0",
42-
# TODO(3461) and external issue cnr-isti-vclab/PyMeshLab/issues/398: Unrestrict Windows version when it isn't broken anymore.
4342
"pymeshlab>=2022.2.post2; platform_machine != 'arm64' and platform_machine != 'aarch64'",
44-
"pymeshlab<2023.12.post2; sys_platform == 'win32' and platform_machine != 'arm64' and platform_machine != 'aarch64'",
4543
"pyngrok>=5.1.0",
4644
"python-socketio>=5.7.1",
4745
"pyquaternion>=0.9.9",
@@ -162,7 +160,7 @@ reportMissingImports = "warning"
162160
reportMissingTypeStubs = false
163161
reportPrivateImportUsage = false
164162

165-
pythonVersion = "3.8"
163+
pythonVersion = "3.10"
166164
pythonPlatform = "Linux"
167165

168166
[tool.ruff]

0 commit comments

Comments
 (0)