-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/Sample] Loading Screen #480
Comments
This feature is really cool. Could you push a PR (Pull Request) for this change? |
Hello @bakes82, This is a copy of the message from the above mentioned PR, but unfortunately, Neozhu already merged that PR, so we can further discuss the changes here, and perhaps create a new PR when necessary.I want to express my gratitude for your assistance – it has been incredibly valuable. The loading screen component you've crafted is truly impressive, and I'm thoroughly impressed with its design. I'd like to bring up a couple of points for consideration. Currently, the loading screen lacks user customization options, specifically the ability for administrators to choose whether they want to enable or disable it, as well as the option to adjust the duration it remains visible. This level of flexibility would be quite beneficial, given the variability in server performance. Of course, you already added the duration parameter as an option, but this cannot be set without touching the code itself, or I have overlooked something 😇. On a related note, I've already incorporated the customization features for enabling/disabling the loading screen and modifying its duration within this pull request. On a different topic, I've encountered a bit of a puzzle. When users who aren't logged in attempt to do so, they encounter the waiting screen – which makes sense. However, after a successful login, the loading screen reappears. My assumption is that our internal authentication controller might be responsible, potentially due to browser redirection and forceful reloading to ensure data accuracy. If it's possible within your availability, could you please look into this issue? The goal is to streamline the experience so that non-logged-in users don't encounter the loading screen twice. Additionally, I've been wondering if the content behind the loading screen is actually rendering components. Currently, it seems like the loading screen is displayed without any real content rendering until the loading screen is finished. This becomes evident when I toggle the loading screen on or off – the time it takes for me to be logged in remains the same, as indicated by the loading icon in the top left corner where your username is displayed. While a purely cosmetic loading screen might be unnecessary, I might be overlooking something, or my device is too quick to be able to see a difference in rendering. Thank you for your dedication and expertise in addressing these matters. Kind regards, |
The loading screen isn't designed to be customized w/out code, per se. I did implement your enable flag and other tweaks, so it can be used like a more generic blocker. It's just a component like everything else, you can choose to use it or not. Yes its cosmetic, you can see data loading behind the screen, it's more to make the transitions between pages flow a bit better, you might not like it or want to use it. Why I didnt originally do as a PR. For me and my application users the hard screen loading w/out a transition feels more abrupt/clunky, so on pages where you do data loads, it can obscure the initial loading or make it appear shorter because of the transition, even though if there was no loading screen it would be the same amount of time just a different loading animation and they think oh the data is already there thats fast ;) Im not a UX designer, but I know some of the basic principles and if showing a animation/loading screen tends to give the perception of things being faster even if its not |
Implemented! |
LoadingScreen.razor (Create new)
App.razor (Modify)
The text was updated successfully, but these errors were encountered: