Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rust to 1.71.0 #4718

Merged
merged 3 commits into from
Jul 14, 2023
Merged

Update rust to 1.71.0 #4718

merged 3 commits into from
Jul 14, 2023

Conversation

vadim2404
Copy link
Contributor

ref neondatabase/build#60

@vadim2404 vadim2404 requested review from koivunej and shanyp July 14, 2023 12:17
@vadim2404 vadim2404 requested review from a team as code owners July 14, 2023 12:22
@vadim2404 vadim2404 requested review from lubennikovaav and removed request for a team July 14, 2023 12:22
@github-actions
Copy link

1032 tests run: 981 passed, 0 failed, 51 skipped (full report)

koivunej
koivunej approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Need to remember to confirm and if necessary implement those gdb visualizers for utils::id::{TenantId, TimelineId} :)

@vadim2404 vadim2404 merged commit e767ced into main Jul 14, 2023
@vadim2404 vadim2404 deleted the vk/update_rust_to_1.71.0 branch July 14, 2023 16:34
@arpad-m arpad-m mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koivunej koivunej koivunej approved these changes

@skyzh skyzh skyzh approved these changes

@shanyp shanyp Awaiting requested review from shanyp

@lubennikovaav lubennikovaav Awaiting requested review from lubennikovaav lubennikovaav was automatically assigned from neondatabase/compute

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vadim2404 @koivunej @skyzh