fix(pageserver): ensure GC computes time cutoff using the same start time #10193
+28
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyzh
force-pushed
the
skyzh/watermark-compute
branch
from
4c7f881 to
74c2f20
Compare
7095 tests run: 6796 passed, 0 failed, 299 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
72c1deb at 2024-12-20T18:14:00.870Z :recycle: |
arpad-m
approved these changes
Dec 19, 2024
…time Signed-off-by: Alex Chi Z <[email protected]>
Co-authored-by: Arpad Müller <[email protected]>
Signed-off-by: Alex Chi Z <[email protected]>
skyzh
force-pushed
the
skyzh/watermark-compute
branch
from
1b01e11 to
7184b22
Compare
Signed-off-by: Alex Chi Z <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
…time (#10193) ## Problem close #10192 ## Summary of changes * `find_gc_time_cutoff` takes `now` parameter so that all branches compute the cutoff based on the same start time, avoiding races. * gc-compaction uses a single `get_gc_compaction_watermark` function to get the safe LSN to compact. --------- Signed-off-by: Alex Chi Z <[email protected]> Co-authored-by: Arpad Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
close #10192
Summary of changes
find_gc_time_cutofftakesnowparameter so that all branches compute the cutoff based on the same start time, avoiding races.get_gc_compaction_watermarkfunction to get the safe LSN to compact.