Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config in defaultconfigs is ignored when correcting single values in a config file #158

Open
Fuzss opened this issue Jun 3, 2024 · 0 comments

Comments

@Fuzss
Copy link

Fuzss commented Jun 3, 2024

When single config values need to be corrected (think like the config value is a number 1-10, but the user enters an incompatible input like '15', in that case only this single value needs fixing not the whole file),
Forge restores the mod specified built-in default value for that option, but ignores a value that is set in a possibly present default config in 'defaultconfigs'.
The expected behavior would be to first check for a value in a default config from 'defaultconfigs' before falling back to the mod specified built-in default.

Example: An int value allowing a range of 1-10.
The built-in value set by the mod is 5.
A config present in defaultconfigs specifies 7 for that value.
The user enters 15.
-> The value is corrected to 5, not 7 as would be expected.

This isn't really a bug, but more of an oversight with how default configs are designed. Just thinking that logically default configs should serve as the default not just when a config is first created, but also when individual values are restored / corrected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant